Add devcontainers-extra versions from the collections index for installsAfter#8
Conversation
|
@lakkeger Please review at your earliest convenience. Many Thanks |
frankpengau
changed the title
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Hey @frankpengau! Thanks a lot for your contribution!
Could you give us a bit more context on the change you are suggesting?
Should these versions be added in addition or should they be replace the "contrib" features?
|
I was adding them in addition to the existing ones, just in case if anyone is still pulling in the old ones. But happy for you to replace them and release a new version and just advise others to stay on older version if they want to use previous devcontainers-contrib ones instead. |
|
@alexrashed Any updates on this one? Happy to either change it and release as new version or merge it? If not needed, happy to just close it off and I'll just fork it? |
|
Thanks a lot, @frankpengau! I think we should just remove the "old" / deprecated contrib extra. |
pinzon
left a comment
pinzon
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your contribution. I'll trigger a release later.
3 participants
Adding
devcontainers-extraversions forinstallsAfter."ghcr.io/devcontainers-extra/features/aws-cdk","ghcr.io/devcontainers-extra/features/pulumi",Ref: